Repository navigation
provider-skip: clear the no-model banner once a model is usable (CL-9911) - #1099
Merged
Merged
Conversation
…invalidate on credential change (CL-9911)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: skipping model setup stored a per-user flag that nothing cleared, so the no-model banner persisted after a model was connected.
Fix: the banner reads the tenant's resolved catalog (same read and
hasUsableModelcheck the settings use) and clears the flag once any model has an offering.Reproduced:
provider-skip.test.tsfailed on origin/main (missingclearProviderSkipWhenUsable), passes now.Gates: typecheck (since origin/main), lint, fmt:check pass; machine load was >40 so only the focused test file was run.