Repository navigation
CL-9721: Pre-fill MCP server name from URL and serverInfo - #1089
Merged
Merged
Conversation
Covers deriving a display name from serverInfo (title, then name) with URL-host and plain fallbacks: trimming, capping, de-duping, and null-safe handling of empty/invalid URLs.
The Tools page's add-by-URL card now fills the server name from the pasted URL's host, offers a hub-probed lookup of the server's own reported name, and keeps every suggestion editable with its source shown. Names and handles are trimmed and de-duped against connected servers; an unreachable server keeps the URL suggestion.
TheGreatAxios
force-pushed
the
cl-9721-mcp-prefill
branch
from
October 3, 2026 17:09
f339931 to
af78b6d
Compare
CL-9780 disables the new-workbench composer until workspace roles have loaded. First-run e2e was clicking Start while the send button was still disabled, so every suite that goes through first-run timed out after the merge.
After CL-9782 the connected-server row reads "1 tool live". The prefill suite still waited for the old plural string and timed out.
TheGreatAxios
marked this pull request as draft
October 7, 2026 17:25
Contributor
|
@TheGreatAxios, please address the following:
|
Cover the fixes for the reviewed PR: an internationalized host reads back as its real name, an IPv6 loopback gets a meaningful handle, a token-refused server is marked as needing a bearer, and a typed name survives a look-up. Brings the e2e flow's hint/button selectors up to the new name-row markup.
A suggestion never clobbers what was typed: look-up only resets the edit flag
when the field had not already been edited. International host names decode
from Punycode before being humanized, and an IPv6 loopback reads as
'localhost' instead of a degenerate slug.
Discovery failures now distinguish a token-refused server ('add it below')
from one that never answered ('check the URL'), and the no-name lookup no
longer toasts. The add-by-URL card's name row gains its own group so the long
hint wraps on full width, the look-up button meets the 44px touch target,
the inline flex spacer and bare rem gap give way to the 4/8/16px rhythm, and
the hint is wired to the field with aria-describedby.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements CL-9721.
The Tools page's add-by-URL card now pre-fills the server name:
Verification: apps/web 99/99 unit tests pass (14 new in mcp-server-name.test.ts); e2e/mcp/oauth-connect passes; repo typecheck/lint/fmt green. Remaining e2e and no-test-file workspace failures reproduce identically on main.