Repository navigation
fix(web): the Settings dialog hosts its embedded Insights route at the runs path (CL-9786) - #1086
Merged
TheGreatAxios merged 2 commits intoOct 3, 2026
Conversation
…e runs path (CL-9786)
…proof (CL-9786) The Settings dialog hosts its embedded Insights route with embedded: crumb links, run-row top-level navigation, and the host sidebar toggle are all suppressed (a run opens inline in local state with a back button), so nothing inside the dialog navigates the host app out from under it. Adds e2e/browser/settings-dialog.test.ts: open Settings, click Insights, assert the dialog stays mounted with the runs panel, assert no embedded chrome links/toggle, then Close and assert dismissal.
TheGreatAxios
deleted the
cl-9786-fixweb-settings-dialog-section-buttons-close-the-dialog
branch
October 3, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why: the dialog embedded the full-page InsightsRoute with no path prop, so it fell back to the host URL (/settings/insights), parsed as a landing page, and redirected top-level — unmounting the dialog. The embedded route is now hosted at the runs path, which renders inline. Includes a red/green keeper test asserting the section hands the route an explicit non-landing path. Fixes CL-9786.