Skip to content

test: synchronize OAuth connect popup and simplify coverage - #1084

Merged
TheGreatAxios merged 1 commit into
mainfrom
test/oauth-connect-cleanup
Oct 2, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
test/oauth-connect-cleanup

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • Change only e2e/mcp/oauth-connect.test.ts; no production code or unrelated package changes.
  • Synchronize the OAuth callback popup before clicking Sign in, wait for completion, and return focus to Tools before checking discovery.
  • Capture the workspace credentials request once, validate browser results with ArkType, remove redundant bookkeeping, and close the page in finally.
  • Retain coverage for OAuth-backed tool discovery, successful authenticated discovery, credential deletion, and subsequent discovery failure (404).

Validation

Exact-branch validation on test/oauth-connect-cleanup, based on main at 413ab7e80f3c251f542f67f1580e7d2ef0c9c17b:

  • bun install --frozen-lockfile: exit 0; tracked lockfile unchanged.
  • bun run check: exit 1. Typecheck, lint, and formatting passed; lint reported three warnings. The unit-test phase failed because six unchanged packages have test scripts but no discoverable tests: @corbits/deferred-tools, @corbits/approvals, @corbits/worker, @corbits/url-path, @corbits/workflows, and @workbench/hub.
  • git diff --check: exit 0.
  • git diff --exit-code origin/main -- packages/deferred-tools packages/approvals packages/worker packages/url-path workflows apps/hub: exit 0 during validation, confirming those paths were unchanged.
  • Exact-branch bun test e2e was launched, but its completion result was unavailable; no exact-branch E2E pass is claimed.
  • Prior-checkout evidence only: three focused OAuth passes and 20/20 E2E tests passed. These results are not exact-branch validation.

This PR is opened with an explicitly authorized exception to the pre-commit gate requirement, documenting rather than fixing the unchanged baseline test-discovery failures. The full gate is not green, and no claim is made that main is green. Tests were not rerun for PR creation.

@TheGreatAxios
TheGreatAxios enabled auto-merge (squash) October 2, 2026 20:44
@TheGreatAxios
TheGreatAxios merged commit 6e57c22 into main Oct 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant