Repository navigation
fix(web): Light theme holds against an OS that prefers dark, and Dark's sidebar sits below the sheet (CL-9659) - #1064
Merged
Conversation
…'s sidebar sits below the sheet (CL-9659)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Light is now explicit: theme-store
apply()and the boot script in index.html setdata-themeand thelightclass on for every non-dark theme (Canvas included, it leaked the same way), so react-ui's:root:not(.dark):not(.light)OS-dark block no longer outranks the token remap.Verified with agent-browser and
prefers-color-scheme: darkforced: in Light, --foreground #2b2627, --card #fff, --primary #2b2627; /workers and /tools render light.Dark's sidebar/canvas (#0e0e0e) already sits below the sheet (#181818) and matches .mockups/tokens.css; the same-tone look was the leak, so no token change.
Resolves CL-9659