Repository navigation
test(e2e): one bootHub helper owns every hub's lifecycle (CL-9621) - #1045
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e2e/lib/hub.ts: bootHub() owns a hub's disposable data dir, env, shutdown, sidecar reaping (moved from browser.ts) and cleanup. Browser, composition (two hubs) and grants suites use it; it is the only createHubServer import under e2e/.
Must be called synchronously in the gated describe body, because Bun runs an afterAll registered inside a hook or test immediately; it returns a getter for the booted hub.
Verified: bun test e2e passes twice on one fresh database and no apps/sidecar process survives.
Resolves CL-9621