Repository navigation
fix(e2e): browser suites tear the hub down and stop colliding on one database (CL-9619) - #1044
Merged
Merged
Conversation
…database (CL-9619) createHubServer returned no way to stop its schedulers, cron ticker, OAuth refresher or DB pool, and the process provisioner's sidecars outlive the hub by design. Each browser file left all of it running against the shared database. The hub now exposes shutdown(); the harness calls it, reaps the file's sidecars from their pid files, and creates the data dir per file at run time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser e2e files left their hub running: createHubServer had no stop, so its allocation/dispatch/cron/OAuth tickers kept reconciling the shared database, and spawned sidecars (which outlive the hub by design) redialed a dead port forever.
Verified: full e2e/browser passes 3 times in a row on one database with no leaked processes.
Resolves CL-9619