Skip to content

fix(hub): serialize boot migrations with an advisory lock (CL-9605) #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Sep 30, 2026
Merged

fix(hub): serialize boot migrations with an advisory lock (CL-9605) #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions apps/hub/src/migrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,21 @@ function databaseUrlFrom(config: HubMigrateConfig): string {
export async function migrateHub(
config: HubMigrateConfig,
db: Parameters<typeof runArtifactMigrations>[0],
): Promise<void> {
// Concurrent boots against one database (parallel e2e suites, rolling
// deploys) would race on the one-shot platform SQL's CREATE TYPE. The
// transaction-scoped advisory lock serializes whole migrations.
await db.transaction(async (tx) => {
await tx.execute(sql`select pg_advisory_xact_lock(${MIGRATE_LOCK_KEY})`);
await applyMigrations(config, db);
});
}

const MIGRATE_LOCK_KEY = 7_460_391_205;

async function applyMigrations(
config: HubMigrateConfig,
db: Parameters<typeof runArtifactMigrations>[0],
): Promise<void> {
const databaseUrl = databaseUrlFrom(config);
const schema = config.schema ?? "public";
Expand Down
Loading