Repository navigation
fix(web): the shell works at phone width with an overlay sidebar and full-width drawer (CL-9590) - #1011
Merged
Conversation
…full-width drawer (CL-9590)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 860px and below the sidebar becomes an off-canvas overlay (transform) opened by a Toggle sidebar button at the top-left of the stage; it closes on navigation, Escape, or scrim click.
The bench drawer becomes a full-width overlay with its scrim.
With the sidebar out of the flow, the main pane gets the full width, so
/no longer renders crushed or blank.Styles live in shell/shell-narrow.css and bench/drawer-narrow.css.
Resolves CL-9590