Repository navigation
fix(prompt-input): close popups on intent only, name chosen option - #150
Merged
TheGreatAxios merged 1 commit intoOct 31, 2026
Merged
Conversation
Addresses corbitsdev#142 findings 12, 13, 14, 17 and 18. - 12: a closed model or mode picker is named for its field and its choice ("Model, Deep") rather than the label alone; the browser tests query that combined name. - 13: an Escape that ends an IME composition is left to the IME and no longer closes a host-opened add, model or mode popup. That covers `isComposing` and Safari's keyCode 229, sent once `isComposing` has already turned false. - 14: a popup whose items, models or modes run out closes, telling its owner once, and stays closed when they return. - 17: splitPromptSegments skips empty tokens, which matched without advancing and looped forever. - 18: the full-chat story's "Use a command" puts the `/` at the start of a line, where a command can begin, so the command list opens. "Mention an agent" already opened its list: the hook re-reads the caret after a host edit, so the issue's stated cause did not reproduce; the new browser test covers both items.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
TheGreatAxios
approved these changes
Oct 30, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Review · Approve
Includes the chosen option in closed PromptInputModelSelect and PromptInputModeSelect combobox names, ignores IME composition Escape (isComposing and keyCode === 229) in useClaimEscape, closes toolbar popups when their options become empty, skips empty tokens in splitPromptSegments, and places / on a new line in the full-chat story's "Use a command" action.
Findings
src/hooks/use-prompt-input.ts:167(informational) — WhileuseClaimEscapeinsrc/ui/prompt-input-toolbar.tsx:88andonKeyDowninsrc/hooks/use-prompt-input.ts:241both ignoreevent.isComposing || event.keyCode === 229, the window-captureclaimEscapelistener insrc/hooks/use-prompt-input.ts:167only checks!event.isComposingwithout&& event.keyCode !== 229.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PromptInputtoolbar and token fixes (findings 12, 13, 14, 17 and 18).isComposingand Safari'skeyCode === 229, which Safari sends afterisComposinghas already turned false.useClosedWhileDisabledbecomesuseClosedWhileUnavailable).splitPromptSegmentsskips empty tokens, which matched without advancing and looped forever./at the start of a line, where a command can begin, so the command list opens. "Mention an agent" already worked; the new browser test covers both items.Verification
bun run checkbun run test:e2e, with new cases ine2e/full-chat.spec.tsand the updated picker names ine2e/prompt-input-toolbar.spec.tsisComposingandkeyCode 229for the add and model popups, and fail without the guard.Closes #142