Skip to content

Input focus outline is clipped in the Dialog left-sheet story #39

Closed

Description

@pratikbuilds

Problem

In Primitives → Dialog → Left sheet, focusing the Owner input clips the orange focus outline at the left and right edges. The top and bottom remain visible, leaving the outline looking cut off. Its bottom edge also sits too close to the Name contains label below.

This makes the focused field look broken and crowds the separation between the two fields.

Reproduce

  1. Run bun run stories.
  2. Open Primitives → Dialog → Left sheet (?story=primitives--dialog--left-sheet).
  3. Click Open left sheet, then focus the Owner input.

Expected

The focus indicator is fully visible around the input, with clear separation from the next field’s label.

Screenshot

Image

Activity

  1. pratikbuilds commented on Sep 10, 2026

    @pratikbuilds
    CollaboratorAuthor

    The Same issue is in workbench in drawers and modals all the input fields are getting clipped. We need to fix it at the root which is here. So two solutions either we increase the box padding and make space for the outer border or remove the outer border with just simple on the input field border

  2. pratikbuilds commented on Sep 10, 2026

    @pratikbuilds
    CollaboratorAuthor

    what are your thoughts on this @TheGreatAxios

  3. TheGreatAxios commented on Sep 10, 2026

    @TheGreatAxios
    Contributor

    It's better than it is, but it's interesting that this shape the horizontal outline disappears

  4. pratikbuilds commented on Sep 10, 2026

    @pratikbuilds
    CollaboratorAuthor

    ya agreed i think we gotta fix the horizontal padding on all components in workbench then and add this notes in design.md as well

  5. TheGreatAxios commented on Sep 30, 2026

    @TheGreatAxios
    Contributor

    Closing this for now -- as Workbench is getting a new round of changes and we'll see if they need to be upstreamed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions