Repository navigation
refactor(triage): decide whether a pull request may merge in one place (CL-12170) - #853
Merged
TheGreatAxios merged 1 commit intoNov 5, 2026
Conversation
Contributor
|
Merged before Triage finished on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Whether Triage may merge a pull request is now decided by one function,
mergeGatein triage-contracts. It returns either allowed or a typed refusal with a cause (changes requested, review threads, or CI) and a reason.heldApprovals) and both executors (GitHubdo.ts, Bitbucketaction.ts) call it. Their own copies of the CI, changes-requested and thread checks are gone.mergeableCiis replaced by the gate.ciRefusaland the head CI type move from github-reads to triage-contracts.changesRequestedfact. The merge is skipped and shown as waiting, the same way an open review thread holds it.mergeVetostill runs after the gate.Verification
bun run checkandbun run lintpass.bun --conditions=intx-src test ./packages ./tests/model(local Postgres): 764 pass, 0 fail.bun --conditions=intx-src test --parallel=2 tests/chain: 13 pass, 0 fail.Refs CL-12170