Repository navigation
fix(web): don't offer merge when GitHub blocks it - #414
Merged
TheGreatAxios merged 1 commit intoOct 21, 2026
Merged
Conversation
TheGreatAxios
marked this pull request as ready for review
October 21, 2026 00:21
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve. |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
force-pushed
the
cl-11029-dont-offer-merge-when-github-blocks-it
branch
from
October 21, 2026 00:26
fa9f905 to
b120823
Compare
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The portal offered Merge on PRs that GitHub reports as
mergeable: truebutmergeable_state: blocked, for example when a ruleset requires a review.reviewDecision(GraphQL) only when the state isblocked. A failed read leaves it null, and details still load.mergeVetoes).message.Out of scope: the inbox list still groups a blocked PR under Merge. CL-11030 covers the list.
Verified: reproduced on corbitsdev/workbench#1133 (
blocked,REVIEW_REQUIRED), and a clean PR still offers Merge. Ranbun run check, lint andbun run test(all pass). New hub tests cover the GraphQL call only when blocked, a failed read, and the refusal text.Closes CL-11029