Repository navigation
refactor!: replace ModelRequestError with RerankRequestError - #9
Merged
Conversation
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review: diff checked against ticket outcomes; independent critique pass run, findings on README wording, registry example and CONTRIBUTING commands fixed. Typecheck, tests, prettier and build pass.
TheGreatAxios
force-pushed
the
cl-9147-reranking-replace-copied-transport-and-modelrequesterror
branch
from
September 25, 2026 14:16
856bdfb to
a548268
Compare
TheGreatAxios
changed the base branch from
main
to
cl-9157-reranking-move-intx-to-peerdependencies
September 25, 2026 14:16
TheGreatAxios
force-pushed
the
cl-9147-reranking-replace-copied-transport-and-modelrequesterror
branch
from
September 25, 2026 17:32
a548268 to
a2109cd
Compare
This was referenced Sep 25, 2026
TheGreatAxios
force-pushed
the
cl-9147-reranking-replace-copied-transport-and-modelrequesterror
branch
from
September 26, 2026 01:30
a2109cd to
d597e95
Compare
Failures now raise RerankRequestError, carrying the classified InferenceError as reason plus the request URL. Malformed replies and out-of-range indices classify as protocol_mismatch through the same class; adapters signal them with ProtocolMismatchError per the @intx/inference parser contract. Config errors, including a missing model for cohere and voyage, throw arktype's TraversalError. The JSON request helper and its Retry-After extractor are no longer exported from the package.
TheGreatAxios
force-pushed
the
cl-9147-reranking-replace-copied-transport-and-modelrequesterror
branch
from
September 26, 2026 01:30
d597e95 to
a9aa3d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RerankRequestError extends Errorwithreason: InferenceErrorandurl, exported from the barrel;ModelRequestErroris deleted.@intx/inferenceclassifiers; retries usecreateDefaultRetryPolicy.ProtocolMismatchErroron malformed replies (theResponseParsercontract), whichrerankDocumentswraps as aprotocol_mismatchRerankRequestError. Out-of-range indices raise the same.TraversalErrorvia.assert.Verification
bun install --frozen-lockfile,bunx tsc --noEmit,bun test ./src,bunx prettier --check .,bun run buildpass.Closes CL-9147
Closes CL-9153