Skip to content

fix: send text document attachments as input text - #41

Merged
TheGreatAxios merged 4 commits into
mainfrom
fix/text-document-input
Nov 4, 2026
Merged

TheGreatAxios merged 4 commits into
mainfrom
fix/text-document-input

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-12064

Base64 documents whose MIME type Interchange's isTextLikeMimeType counts as text (text/*, JSON, +json, parameters such as ; charset=utf-8 ignored) are decoded as UTF-8 and sent as input_text; invalid UTF-8 throws. PDF, file-reference and URL handling unchanged. Adds media-input encoding tests: text documents (including MIME parameters and flat shape), PDF, and base64, URL and file-reference images.

@linear-code

linear-code Bot commented Nov 4, 2026

Copy link
Copy Markdown

CL-12064

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Live check, gpt-5-mini on api.openai.com, all open PRs merged locally: text/markdown; charset=utf-8 document, PDF and base64 PNG input all reach the model, which answers from their contents correctly.

@TheGreatAxios
TheGreatAxios merged commit 141ac54 into main Nov 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant