Repository navigation
feat(login): add loginWithProvider - #19
Merged
TheGreatAxios merged 2 commits intoSep 27, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-9135-oauth-core-add-loginwithproviderprovider-save-helper
branch
3 times, most recently
from
September 25, 2026 21:26
91436ee to
b34ae3c
Compare
Merged
OAuthLoginProvider and callbackTargetFor need neither hono nor @intX, so they move to the root entry and leave the hub entry. The hub mount's callback pages move with them and drop the workbench-specific copy.
It runs the loopback PKCE login against a provider's fixed redirect_uri, saves the profile, and returns it. Hosts that need their own callback pages, or to show the staged profile before committing it, keep using startOAuthLogin.
TheGreatAxios
force-pushed
the
cl-9135-oauth-core-add-loginwithproviderprovider-save-helper
branch
from
September 26, 2026 01:29
b34ae3c to
9d60098
Compare
TheGreatAxios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuthLoginProvider,OAuthLoginProviders,callbackTargetForand the shared callback pages (signedInHtml,signInFailedHtml) live insrc/provider.ts;src/hub/registry.tsis deleted.OAuthLoginProviderandcallbackTargetForexport from the root and leave./hub;OAuthLoginProvidersstays on./hub.loginWithProvider(provider, { save, profile, signal, openInBrowser })runs the loopback PKCE login against the provider's fixed redirect_uri, exchanges the code withprovider.exchange, saves viasave, and returns the profile. All options are required;provider.metadatais not applied (documented in the doc comment).main; chore(release): 0.2.0 #20 is stacked on it.Verification
bun install --frozen-lockfile,bun run check(typecheck, lint, format:check, 55 tests),bun run build: pass. A new test drives a real loopback callback on a free port against a stub provider.Closes CL-9135