Repository navigation
Trim and consolidate the memory test suite - #39
TheGreatAxios merged 1 commit into
Conversation
Parameterized micro-case groups, pruned dead-weight asserts, and reinstalled pristine module snapshots so mock.module stops leaking across test files. Tests only; no production code touched.
ReviewVerdict: approve. MERGEABLE against current The load-bearing change is the Deletions look justified: Does not touch files Do not stack with #40. Both shrink tests off the same 2026-09-17 base and conflict in |
Tests-only consolidation for CL-8219. No production code touched.
Pruned (dead weight with surviving justification):
Consolidated into tables/loops: authorityWeightedScore, snippet, hnswEfSearch, deriveHybridEvidence (search); truncation + budget blocks (rerank-client); clamp/bound/temporal (hybrid-search); config-validation (degrade-metrics); 500 quartet (deps); whitespace trio (routes); migration CHECK + arktype lockstep (enums.lockstep).
Shared fixture: routes.test.ts builds one Hono app per harness (browser + machine-caller) instead of per test; grants, catalog, session principal, and callerResolver flow through mutable boxes reset by the existing buildApp signatures, so test bodies are unchanged.
Mock leak: memory.test.ts snapshots pristine module namespaces before mocking and reinstalls them in afterAll (mock.restore leaves module mocks installed); search.test.ts cache-busted dynamic import removed in favor of a static import.
Kept intact (judged load-bearing, flagging for follow-up): the no-embed lexical-results test and the HTTP-layer ownership 403 tests; the route stub was not slimmed.
Verification: