Repository navigation
Address pre-publish review findings for corbits-embedding - #1
Merged
TheGreatAxios merged 3 commits intoSep 21, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
Reject batchSize below 1 at the embedTexts entry boundary, document installation and transport exports, and complete the publish metadata.
Contributor
Author
ReviewVerdict: comment. MERGEABLE. CI check green, 20 tests. No prior reviews. batchSize < 1 now throws RangeError at embedTexts. Should-fix: this PR documents npm install @corbits/embedding and engines.node >= 20, but packed dist/index.js uses extensionless from "./embed". Node import of the tarball throws ERR_MODULE_NOT_FOUND. Bun loads it. CI is bun-only. Nit: EmbedConfigSchema batchSize is number > 0 (accepts 0.5); runtime is !(batchSize >= 1). Safe direction, schema/runtime disagree. |
npm view @corbits/embedding 404s; git is the install path. Default export is dist/; native Node does not load extensionless TypeScript source.
Node cannot import extensionless relative specifiers from packed dist. Source relative imports now carry .js so tsc emits Node-loadable ESM. EmbedConfigSchema and embedTexts both require batchSize integer >= 1, rejecting 0.5 and NaN.
Contributor
Author
Re-reviewVerdict: approve. SHA 6ca6878. Packed dist emits |
TheGreatAxios
deleted the
cl-8192-address-pre-publish-review-findings-for-corbits-embedding
branch
September 21, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes CL-8192