Repository navigation
Deny OAuth token stores in the secret guard - #983
Merged
TheGreatAxios merged 3 commits intoSep 13, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
Collaborator
Author
|
Audit: Approve. Problem/solution fit: token stores under ~/.corbits were readable via read_file/@mention with no denylist entry — now covered with resolved-path parity. File-for-later (do not implement here): (1) scanner *-auth.json-only window, (2) copied-credential-outside-settings-dir gap. |
Codex, xAI, and per-server MCP OAuth tokens live under ~/.corbits but had no denylist entry, so read_file and @mentions could exfiltrate them. Each auth store now enumerates its own filenames, a data-only registry turns them into denylist patterns with backup and sidecar coverage, and mention resolution expands ~ and checks the resolved path at both gates.
TheGreatAxios
force-pushed
the
cl-7789-the-secret-guard-denylist-omits-the-products-own-oauth-token
branch
from
September 13, 2026 16:34
b657261 to
0497d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Credential paths are enumerated by the auth layer and spread into the secret-guard denylist, covering codex-auth, xai-auth, the mcp-auth directory, and backup sidecars (.bak, lock, tmp, tilde, swap). Mention resolution uses the same resolved-path check as tools with home expansion.
Verification
bun run check passes (7139 tests, 0 fail), including default-install regression and fail-build coverage scanner tests.
Fixes CL-7789