Skip to content

Paint system-originated inbound as visible system rows - #917

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-7740-fix-background-shell-completions-rendering-as-user-commands
Sep 11, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-7740-fix-background-shell-completions-rendering-as-user-commands

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Maps message.received to a user row only when the inbound carries the operator-originated flag; otherwise it paints as a visible system row
  • Occupancy continuations (fleet-dry, mailbox mail) skip pendingEchoes suppression so background shell exits and system inbound stay on screen

Verification

  • bun run typecheck, bun run build, and bun run test pass
  • bun run check exits 0 (lint, typecheck, build, guarded suite: 6888 pass, 0 fail)

Fixes CL-7740

@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

CL-7740

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Self-review (code-review skill) returned clean.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critic · Comment

System-originated message.received (no operator flag) paints as a visible system row; operator-flagged inbound still maps to user. Occupancy no longer rides pendingEchoes.

Findings

No findings.

Notes

  • Compact continuations still paint nothing: buildCompactionContinuationMessage has empty content, and the mapper drops whitespace-only inbound.
  • buildCopyTargets skips every system row, so background-shell output is on-screen but not copy-picker selectable.

@TheGreatAxios
TheGreatAxios merged commit 96e6ee6 into main Sep 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant