Skip to content

fix(provider): skip top p when custom setup temperature is set - #1314

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-9854-custom-provider-setup-lets-you-fill-both-temperature-and-top
Oct 5, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-9854-custom-provider-setup-lets-you-fill-both-temperature-and-top

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Custom provider setup skips the top p step when temperature is set and clears any previously entered top p, so both sampling fields cannot be submitted together.
  • Leaving temperature blank still offers top p. Back from a later step lands on the sampling field that is actually set.
  • Wizard submit, including Ctrl+S, also clears top p when temperature is set. The schema still rejects both if a caller bypasses the form.

Verification

  • bun run typecheck, bun run build, and bun run test pass
  • bun run check passes (lint, typecheck, dead-exports, build, guarded suite)
  • Co-located helper tests cover skip, back, clear, zero-as-set, whitespace-as-unset, and no-op on lists without sampling steps

Fixes CL-9854

The schema already refuses both sampling fields on the wire, but the
wizard still walked temperature then top p and only failed at save.
@linear-code

linear-code Bot commented Oct 3, 2026

Copy link
Copy Markdown

CL-9854

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review · Approve

Custom provider setup skips and clears top p when temperature is set, still offers top p when temperature is blank, and submit (including Ctrl+S) clears top p before the schema XOR.

Findings

No findings.

@TheGreatAxios
TheGreatAxios merged commit 6d2755d into main Oct 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant