Repository navigation
refactor(agent): compare tool names through a single helper - #1292
Merged
TheGreatAxios merged 1 commit intoOct 2, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
Wire-name aliases previously leaked into engine-name comparisons and broke tracking; each new alias required hunting every callsite. Both sides now resolve through canonicalToolName first, so future projections only touch the alias tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isSameToolhelper that resolves both sides viacanonicalToolName, so future wire renames and per-family projections only touch the alias tables===remains in those pathsread/bash/todowrite/shell/update_plan/wait) in task tracking, LSP triggers, watchdogs, and transcript rowsVerification
bun run checkpasses (lint, typecheck, dead-exports, build, guarded test suite: 8028 pass / 0 fail)canonical-tool-name.test.tsplus aliased-name cases across director, poll-exempt, and watchdog tests; fail-then-pass confirmed via stashFixes CL-9714