Repository navigation
fix(secret-guard): fail closed on dollar-prefixed secret paths - #1286
Merged
Merged
Conversation
A leading $HOME/${HOME} or $USER/${USER} expands from the environment before matching, so $HOME/.ssh/id_rsa asks exactly like the literal path. Any other live $VAR joined to a path separator fails closed to ask, while bare $VAR tokens with no path shape stay invisible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leading $HOME/$USER tokens expand from the environment before matching, so
cat $HOME/.ssh/id_rsaasks exactly like the literal path. Other live $VAR tokens joined to a path separator fail closed to ask; bare $VAR with no path shape stays invisible. Quoted dollars, command substitutions, ANSI-C quotes, and Windows ADS streams are unaffected.Fixes CL-8999