Repository navigation
fix(permission): follow dangling symlinks when judging sensitive paths - #1262
Merged
TheGreatAxios merged 1 commit intoOct 2, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-9632-secret-guard-follows-dangling-symlinks-to-sensitive-targets
branch
from
September 30, 2026 18:05
bdd9476 to
3db37e0
Compare
TheGreatAxios
force-pushed
the
cl-9632-secret-guard-follows-dangling-symlinks-to-sensitive-targets
branch
from
September 30, 2026 23:49
3db37e0 to
0822e0e
Compare
TheGreatAxios
force-pushed
the
cl-9632-secret-guard-follows-dangling-symlinks-to-sensitive-targets
branch
from
October 2, 2026 00:26
0822e0e to
5925533
Compare
Base automatically changed from
cl-9624-remove-the-unused-background-shell-collect-and-waiter-api
to
main
October 2, 2026 16:33
A write through a dangling link to a secret file, such as link -> .env, passed the secret guard because the resolver reported the path as unresolvable. The guard now follows link targets by hand, so the path a write would land on is judged like any other route to that file.
TheGreatAxios
force-pushed
the
cl-9632-secret-guard-follows-dangling-symlinks-to-sensitive-targets
branch
from
October 2, 2026 16:43
5925533 to
ff77f9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link -> .envis denied like any other route to a secret file.write_file,edit_fileandapply_patchshare the check.Verification
bun run checkpasses..envand leave a dangling link to an ordinary file to the gate.Fixes CL-9632