Repository navigation
refactor(shell): remove the unused background shell collect and waiter API - #1261
Merged
TheGreatAxios merged 2 commits intoOct 2, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-9624-remove-the-unused-background-shell-collect-and-waiter-api
branch
from
September 30, 2026 17:35
0f0aaed to
94d0f96
Compare
TheGreatAxios
force-pushed
the
cl-9624-remove-the-unused-background-shell-collect-and-waiter-api
branch
from
September 30, 2026 18:05
94d0f96 to
57342ff
Compare
TheGreatAxios
force-pushed
the
cl-9624-remove-the-unused-background-shell-collect-and-waiter-api
branch
from
September 30, 2026 23:49
57342ff to
0aee266
Compare
TheGreatAxios
force-pushed
the
cl-9624-remove-the-unused-background-shell-collect-and-waiter-api
branch
4 times, most recently
from
October 2, 2026 16:28
c4b2775 to
dd9b137
Compare
Base automatically changed from
cl-9622-apply_patch-re-enforces-secret-guard-and-realpath-workspace
to
main
October 2, 2026 16:31
…r API Nothing polls a background shell since shell_collect was removed: results arrive through onExit and run_shell stop cancels. Drop collect, releaseWaiters, the completed-run ring, and the collect wait cap, and move the registry tests onto onExit.
TheGreatAxios
force-pushed
the
cl-9624-remove-the-unused-background-shell-collect-and-waiter-api
branch
from
October 2, 2026 16:31
dd9b137 to
35d5148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect,releaseWaiters, the waiter bookkeeping, the completed-run ring, and the collect wait cap from the background shell registry. Results arrive throughonExitandrun_shell stop=<id>cancels.onExitrecorder.Verification
bun run checkpasses (7,868 tests across 521 files).Fixes CL-9624