Skip to content

feat(read): diagnose blocked file inspection with a next action - #1232

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-9474-explain-blocked-file-inspection-and-provide-an-actionable
Sep 29, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-9474-explain-blocked-file-inspection-and-provide-an-actionable

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • read_file diagnoses blocked file inspection at first failure: missing PDF extractor vs worker permission boundary vs malformed/unreadable file, each with one concrete next action
  • Workers without run_shell get a permission-boundary message when pdftotext is installed but they cannot execute it; a missing extractor is named as a capability gap, not a bad file
  • Coverage includes the PDF flow (extractor unavailable, then installed but the worker cannot execute) plus malformed and ordinary-binary cases

Verification

  • bun run check passes (lint, typecheck, dead-export guard, build, and the guarded test suite: 7748 pass, 0 fail across 519 files)
  • bun test src/plugins/file-inspection-diagnosis.test.ts src/plugins/read-file-guard-plugin.test.ts passes

Fixes CL-9474

The credential-lock tests imported a path that does not exist, so
typecheck failed on main. Every other mock.module caller already uses
testkit.
read_file used to dump PDFs as text or refuse binaries without saying
whether the gap was a missing extractor, a worker that cannot run host
commands, or a malformed file. The first failure now names that cause
and the concrete unblock.
@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

CL-9474

@TheGreatAxios
TheGreatAxios merged commit b44a74d into main Sep 29, 2026
13 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-9474-explain-blocked-file-inspection-and-provide-an-actionable branch September 29, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant