Skip to content

fix(search): fail closed on unbounded workspace-root search_files - #1225

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-9469-search_files-must-fail-closed-on-unbounded-root-walks
Sep 29, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-9469-search_files-must-fail-closed-on-unbounded-root-walks

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • search_files refuses unbounded workspace-root walks up front with scope guidance instead of walking the whole tree until the time budget fires
  • Timeout errors stay distinct from empty results so a timed-out search never reads as a false negative

Verification

  • bun test src/plugins/search-files-fail-closed.test.ts src/plugins/shell-guard-plugin.test.ts src/plugins/tool-time-budget.test.ts --randomize --seed 424242 passes (77 pass, 0 fail)

Fixes CL-9469

Workspace-root search_files with a recursive glob walked the whole tree
until the shell-guard budget fired, and a timeout reads as a false
negative. Refuse the walk up front with scope guidance instead.
@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

CL-9469

@TheGreatAxios
TheGreatAxios merged commit c3c63a3 into main Sep 29, 2026
13 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-9469-search_files-must-fail-closed-on-unbounded-root-walks branch September 29, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant