Repository navigation
feat(telemetry): record abandoned permission prompts and modes - #1202
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
An abandoned prompt is not a denial: Esc previously manufactured a deny outcome, hiding abandonment from telemetry. Settling with no outcome lets the gate deny the action while reporting what actually happened.
Collaborator
Author
|
Closing as telemetry-only: does not improve operator-facing output, and the PR is not CI-green + trivial after the 0333 merge wave. Reopen if product telemetry is prioritized separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abandoneddecision instead of a synthetic deny; the action is still deniedpermission_promptevents carry the approval mode (interactive) from the approval logslash_commandevent instead of noneVerification
bun run lintpasses; targeted suites pass: telemetry-product-events (24), permission gate/queue plus approval-resume/check-gate plus command registry (139)bun run typecheckreports one pre-existing vendor error (semvertypes missing from the install);check:dead-exportscannot run (ts-prunebinary absent)Fixes CL-9013