Repository navigation
fix(mcp): keep PKCE verifier in memory instead of on disk - #1201
Closed
TheGreatAxios wants to merge 3 commits into
Closed
TheGreatAxios wants to merge 3 commits into
TheGreatAxios wants to merge 3 commits into
Conversation
Collaborator
Author
|
Closing after the 0333 merge wave: rebase onto origin/main hit conflicts, and parent guidance is not to fight those. Reopen on a fresh branch if this still improves operator output without regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP PKCE verifier is now instance-local: saveCodeVerifier no longer writes the auth file, MCPAuthState drops the codeVerifier field, and the stale-token guard only adopts tokens when present. resetAuthorization scrubs a legacy on-disk verifier as a one-version migration.
Review fixes:
Verification: src/mcp + mcp unit suites 181 pass; oauth-provider 28 pass; bun run lint/typecheck/dead-exports/build clean; full suite 8594 pass / 1 fail — tests/integration/exec-signal-finalize SIGINT timing flake that passes in isolation (3 pass) and is unrelated to this change.
Fixes CL-9001