Repository navigation
fix(tui): keep leftover same-name collect under the stall budget - #1108
Merged
TheGreatAxios merged 2 commits intoSep 16, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Two concurrent shell_collect calls share one callIdByName slot, so when the mapping-owning sibling resolves first and clears it, the leftover earlier collect loses its name and pins the turn with no wall-clock bound. Track the tool name per call id (callNameById) in register/ unregister and consult it in isStallBoundedInFlightTool, so the leftover still aborts at the stall budget. Fixes CL-8059
TheGreatAxios
commented
Sep 16, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review
Approve with follow-through.
Dual maps are the right architecture: callIdByName owns name-only collapse; callNameById owns per-id stall names. Do not replace the collapse map.
Make ShouldAbortForStallArgs.callNameById required (no ?? {}). The leftover hole reopens if a caller copies the old fixture shape. Update docs that still describe concurrent same-name collect losing the stall bound.
Will patch on the branch.
The leftover collect after a mapping-owning sibling resolves is only visible on the per-id map. An optional field with an empty fallback would treat that leftover as unbounded.
TheGreatAxios
deleted the
cl-8059-0328-concurrent-same-name-shell_collect-can-lose-stall-bound
branch
September 16, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes CL-8059