Skip to content

fix(hardening): small follow-ups from the 0.3.25 review - #1021

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-7927-small-hardening-and-wording-follow-ups-from-0325-review
Sep 14, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-7927-small-hardening-and-wording-follow-ups-from-0325-review

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • The Codex parallel_tool_calls rewrite passes non-JSON request bodies through unrewritten instead of throwing
  • Grant-mismatch notices echo the force spelling the command actually used
  • Bake-only telemetry prose matches use_skill reporting behavior
  • Markdown link cells in the transcript carry no underline, matching click-only behavior

Verification

  • bun run check passes: lint, typecheck, build, and the full suite (7309 pass, 0 fail across 501 files)
  • Targeted red/green runs pin each behavior before and after the fix

Fixes CL-7927

Failing tests for the Codex non-JSON passthrough, the grant-notice force spelling, and the markdown link underline absence; the telemetry comment softening rides along.
…nk underline

Guard the Codex parallel_tool_calls rewrite with a non-JSON passthrough, echo the typed force spelling in grant-mismatch notices, soften bake-only telemetry prose to match use_skill reporting, and remove the markdown link underline the click-only transcript cannot back with hover.
@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

CL-7927

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Critic review — approve, merge-ready

Small hardening + wording follow-ups; each item checked against the code under review. No blocking findings.

Findings (all non-blocking)

  • src/provider/codex-responses.ts — try/catch passthrough is correct and the new test pins it. Boundary note: only the parse is guarded, so a valid-JSON non-object body (e.g. "null") would still throw TypeError on property assignment (confirmed). The real adapter always emits an object body, so no guard warranted — recorded here only, no action.
  • src/permission/gate.ts + src/permission/gate.test.ts — echoing the matched flag token is accurate; the unchanged first test (--force in, --force out) confirms no drift on the common spelling. Display-only, guard decision untouched.
  • docs/PLUGINS.md, docs/TELEMETRY.md, src/telemetry/classify.ts, tests/unit/telemetry-product-events.test.ts — wording now matches behavior verified in src/extensions/skills.ts:165-168 (disable-model-invocation omitted from listing, explicit loads still resolve) and classifySkillName (idiot-proof/native-runtime report custom).
  • src/tui/stream.ts + src/tui/stream.test.ts — underline removal scoped to link cells; no other dependents on the markup.link underline.

Nits

  • withParallelToolCalls is now exported solely for the test — acceptable, no action.

Verdict

Merge-ready. No blocking issues, tests cover each behavior change, no hygiene regressions per AGENTS.md.

@TheGreatAxios
TheGreatAxios merged commit 2109545 into main Sep 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant