Skip to content

test(e2e): add presenter and approval round regression coverage - #86

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-11929-e2e-approval-regression
Nov 2, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-11929-e2e-approval-regression

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

Adds presenter and approval package E2E regression support on top of the recorded-model E2E test harness (#81) and approval round stack (#57–#61):

  • test/e2e/support/recorded-model.ts:
    • Adds "presenter" to the AgentRole union and classifies presenter turns via write_deck and file_package tools in classifyRole.
    • Exports classifyRole and adds writeScenarioFixture for building recorded scenario bundles in tests.
  • test/e2e/support/recorded-model.test.ts:
    • Adds unit coverage verifying classifyRole across all agent roles including "presenter".
    • Adds multi-run recorded-model replay coverage for coordinator deploy_presenter, presenter write_deck / check_deck / file_package with {{bind:...}} artifact substitution, and coordinator turns receiving external reviewer feedback (--- reviewer feedback (external).
  • test/e2e/pipeline.test.ts:
    • Adds an E2E regression test (drives presenter approval package, reviewer decisions and owner feedback triage to the coordinator) covering presenter deployment, deck authoring and checking, filing an approval_package, starting an approval round, downloading the package zip, recording reviewer request_changes (overall + slide notes) and approve decisions, triaging feedback (dismiss, reply, incorporate) into the coordinator, and settling the approval round.

Closes CL-11929
Refs CL-11935
Refs CL-11938

@linear-code

linear-code Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

CL-11935

CL-11938

CL-11929

@corbits-triage

corbits-triage Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Triage: In progress

Triage is waiting for the decision model's answer before it decides. This comment shows the verdict once it has.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch 2 times, most recently from dc0d48a to 6033887 Compare November 2, 2026 08:12
@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-e2e-approval-regression branch from 12db455 to 6858706 Compare November 2, 2026 08:17
@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch 4 times, most recently from 9ed2f51 to 17c6a3d Compare November 2, 2026 08:52
@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-e2e-approval-regression branch 2 times, most recently from 83112c5 to 8e2fd01 Compare November 2, 2026 09:19
@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch 2 times, most recently from 3fbdebb to 4e0f345 Compare November 2, 2026 09:21
@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-e2e-approval-regression branch from 8e2fd01 to db3e7df Compare November 2, 2026 09:21
@TheGreatAxios
TheGreatAxios force-pushed the cl-11935-send-triaged-feedback-to-the-coordinator branch from 4e0f345 to 71b79b6 Compare November 2, 2026 09:26
@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-e2e-approval-regression branch from 8cc8899 to 8db18c4 Compare November 2, 2026 09:32
@TheGreatAxios
TheGreatAxios changed the base branch from cl-11935-send-triaged-feedback-to-the-coordinator to main November 2, 2026 09:56
@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-e2e-approval-regression branch from 8db18c4 to 8348c07 Compare November 2, 2026 09:57
@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-e2e-approval-regression branch from bb9dbe0 to 7fc3379 Compare November 2, 2026 10:05
@TheGreatAxios
TheGreatAxios merged commit 8bf019c into main Nov 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant