Repository navigation
test(e2e): add presenter and approval round regression coverage - #86
Merged
Merged
Conversation
|
Triage: In progress Triage is waiting for the decision model's answer before it decides. This comment shows the verdict once it has. |
TheGreatAxios
force-pushed
the
cl-11935-send-triaged-feedback-to-the-coordinator
branch
2 times, most recently
from
November 2, 2026 08:12
dc0d48a to
6033887
Compare
TheGreatAxios
force-pushed
the
cl-11929-e2e-approval-regression
branch
from
November 2, 2026 08:17
12db455 to
6858706
Compare
TheGreatAxios
force-pushed
the
cl-11935-send-triaged-feedback-to-the-coordinator
branch
4 times, most recently
from
November 2, 2026 08:52
9ed2f51 to
17c6a3d
Compare
TheGreatAxios
force-pushed
the
cl-11929-e2e-approval-regression
branch
2 times, most recently
from
November 2, 2026 09:19
83112c5 to
8e2fd01
Compare
TheGreatAxios
force-pushed
the
cl-11935-send-triaged-feedback-to-the-coordinator
branch
2 times, most recently
from
November 2, 2026 09:21
3fbdebb to
4e0f345
Compare
TheGreatAxios
force-pushed
the
cl-11929-e2e-approval-regression
branch
from
November 2, 2026 09:21
8e2fd01 to
db3e7df
Compare
TheGreatAxios
force-pushed
the
cl-11935-send-triaged-feedback-to-the-coordinator
branch
from
November 2, 2026 09:26
4e0f345 to
71b79b6
Compare
TheGreatAxios
force-pushed
the
cl-11929-e2e-approval-regression
branch
from
November 2, 2026 09:32
8cc8899 to
8db18c4
Compare
TheGreatAxios
changed the base branch from
cl-11935-send-triaged-feedback-to-the-coordinator
to
main
November 2, 2026 09:56
TheGreatAxios
force-pushed
the
cl-11929-e2e-approval-regression
branch
from
November 2, 2026 09:57
8db18c4 to
8348c07
Compare
TheGreatAxios
force-pushed
the
cl-11929-e2e-approval-regression
branch
from
November 2, 2026 10:05
bb9dbe0 to
7fc3379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds presenter and approval package E2E regression support on top of the recorded-model E2E test harness (#81) and approval round stack (#57–#61):
test/e2e/support/recorded-model.ts:"presenter"to theAgentRoleunion and classifies presenter turns viawrite_deckandfile_packagetools inclassifyRole.classifyRoleand addswriteScenarioFixturefor building recorded scenario bundles in tests.test/e2e/support/recorded-model.test.ts:classifyRoleacross all agent roles including"presenter".deploy_presenter, presenterwrite_deck/check_deck/file_packagewith{{bind:...}}artifact substitution, and coordinator turns receiving external reviewer feedback (--- reviewer feedback (external).test/e2e/pipeline.test.ts:drives presenter approval package, reviewer decisions and owner feedback triage to the coordinator) covering presenter deployment, deck authoring and checking, filing anapproval_package, starting an approval round, downloading the package zip, recording reviewerrequest_changes(overall + slide notes) andapprovedecisions, triaging feedback (dismiss,reply,incorporate) into the coordinator, and settling the approval round.Closes CL-11929
Refs CL-11935
Refs CL-11938