Skip to content

feat(dev): seed approval package and review round in dev seed script - #84

Merged
TheGreatAxios merged 1 commit into
cl-11935-send-triaged-feedback-to-the-coordinatorfrom
cl-11929-seed-approval-packages
Nov 2, 2026
Merged

TheGreatAxios merged 1 commit into
cl-11935-send-triaged-feedback-to-the-coordinatorfrom
cl-11929-seed-approval-packages

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

Follows up on #61 (cl-11935-send-triaged-feedback-to-the-coordinator) and #78 (d5a6ddb) to seed an approval_package deliverable and an open sb_approval_round in bun run dev:seed:

  • Excludes approval_package from awaitingApproval in scripts/seed-projects.ts (listArtifacts), matching apps/hub/src/projects/deploy-tools.ts.
  • Extends test/seed/index.ts and scripts/seed-projects.ts to load and seed an optional approvalPackage bundle (validated with @corbits/slidedeck validateDeck/checkDeck and rendered to .pptx and .pdf via writePptx/writeDeckPdf) and approvalRound row (sb_approval_round) with live source document pins.
  • Adds a 5-slide stakeholder deck (test/seed/clinical-trial-intake/approval-package/deck.json) and open review round (Dr. Elena Vance with request_changes and 3 pending triage items, plus Marcus Thorne in sent state) to clinical-trial-intake so developers can test the approval table, slide deck modal, download package modal, and inline feedback triage immediately after bun run dev:seed.
  • Extends test/integration/seed-projects.test.ts with assertions for the loaded ApprovalPackageBundle and seeded ApprovalRound.

@linear-code

linear-code Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

CL-11929

CL-11953

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • CI green: required checks are failing
    • test

@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-seed-approval-packages branch from 7f59b3d to 3ecf80f Compare November 2, 2026 08:17
@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 08:20

Nothing triage asked to change still fails, so this request no longer stands.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 08:38

This pull request is no longer ready to approve, so this approval no longer stands.

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Merge conflicts: merge conflicts with base

@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-seed-approval-packages branch from 3ecf80f to 30c217e Compare November 2, 2026 08:55
@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 08:59

Nothing triage asked to change still fails, so this request no longer stands.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • CI green: required checks are failing
    • typecheck

@TheGreatAxios
TheGreatAxios force-pushed the cl-11929-seed-approval-packages branch from 6de61da to 17a2c50 Compare November 2, 2026 09:29
@corbits-triage

corbits-triage Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Stacked on #61: only this pull request's own changes were checked.

Notes:

  • changes sensitive paths: locks: bun.lock

Triage will approve, request review, label.

@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 09:41

Nothing triage asked to change still fails, so this request no longer stands.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@TheGreatAxios
TheGreatAxios dismissed corbits-triage[bot]’s stale review November 2, 2026 09:53

The merge-base changed after approval.

@TheGreatAxios
TheGreatAxios merged commit 1f94bea into main Nov 2, 2026
8 checks passed
An error occurred while trying to automatically change base from cl-11935-send-triaged-feedback-to-the-coordinator to main November 2, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant