Skip to content

fix(web): only activate model profiles with connected providers - #83

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11970-only-allow-selectingactivating-model-profiles-whose
Nov 2, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11970-only-allow-selectingactivating-model-profiles-whose

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-11970

Summary

  • Only offer Use and show Active on model profiles in Settings → Profiles when every tier's provider is connected and available; fall back to automaticProfile or the unresolved banner when a previously saved profile's provider is disconnected.
  • Filter the Start from list and tier provider options in the custom profile editor to connected providers (keeping any disconnected provider currently bound on an edited custom profile as a disabled option so it is visible while blocking Save until replaced).
  • Invalidate keys.modelChoice when personal profile settings are saved so the home prompt picker updates immediately.
  • Enforce connected provider availability in invalidModelChoice, resolveModelChoice, and frozenModelChoice on the hub so disconnected profiles cannot be activated or resolved as a project's model choice.

Verification

  • bun run lint
  • bun run format:check
  • bun run typecheck
  • bun run pins:verify
  • bun run vendor:verify
  • bun run test (92 pass across 34 files)

@linear-code

linear-code Bot commented Nov 2, 2026

Copy link
Copy Markdown

CL-11970

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern
    • apps/web/src/pages/profiles.tsx:181-185 nested-ternary: Nested ternary; use if statements or a lookup.
    • apps/web/src/pages/profiles.tsx:232-240 nested-ternary: Nested ternary; use if statements or a lookup.
    • apps/web/src/pages/profiles.tsx:390-397 promise-chain: Promise chain; use async/await with try/catch.
  • Invented fallbacks: added code matches a code pattern
    • apps/web/src/pages/profiles.tsx:444 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
    • apps/web/src/pages/profiles.tsx:457 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
    • apps/web/src/pages/profiles.tsx:490 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
    • apps/web/src/pages/profiles.tsx:510 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11970-only-allow-selectingactivating-model-profiles-whose branch from 35da207 to e280551 Compare November 2, 2026 07:28
@corbits-triage

corbits-triage Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Triage will approve, request review.

@corbits-triage
corbits-triage Bot dismissed their stale review November 2, 2026 07:30

Nothing triage asked to change still fails, so this request no longer stands.

@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 62f7bda Nov 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant