Repository navigation
fix(hub): keep caught errors in the coder's build tools - #8
Merged
TheGreatAxios merged 1 commit intoOct 31, 2026
Merged
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve. |
TheGreatAxios
force-pushed
the
cl-11846-keep-caught-errors-in-the-coders-build-tools
branch
from
October 31, 2026 08:42
7b0585e to
9b7e72f
Compare
TheGreatAxios
deleted the
cl-11846-keep-caught-errors-in-the-coders-build-tools
branch
October 31, 2026 08:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11846 (https://linear.app/abklabs/issue/CL-11846/keep-caught-errors-in-the-coders-build-tools).
Changes
Every catch in the import scan, package install, posix child, posix sandbox and workflow HTTP JSON reader now binds its error. It handles only the failure it expects and rethrows the rest:
BuildMessageorAggregateError) or is gone (ENOENT) has no imports. A missing, unparsable or wrong-shaped manifest gives no manifest.ESRCHorEPERM) falls back to killing the child directly. An invalid URL isn't a public host.launchDevAppwith try/finally instead of an IIFE. Its file-watch restart and page-report reader became named functions, and the?? []destructuring default is gone, all with the same behaviour.Verification
Lint, format, typecheck and tests pass, and Triage's local check passes all code-pattern rules.
An independent review found three regressions:
EPERMfrom a dead process group on macOSnullrefusal body raising a rawTypeErrorAll three are fixed. A second review, which probed Bun 1.4.4's actual error types, found the fixes correct and the rewrites behaviour-identical.