Skip to content

fix(hub): keep caught errors in the coder's build tools - #8

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11846-keep-caught-errors-in-the-coders-build-tools
Oct 31, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11846-keep-caught-errors-in-the-coders-build-tools

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-11846 (https://linear.app/abklabs/issue/CL-11846/keep-caught-errors-in-the-coders-build-tools).

Changes

Every catch in the import scan, package install, posix child, posix sandbox and workflow HTTP JSON reader now binds its error. It handles only the failure it expects and rethrows the rest:

  • Import scan: a file that doesn't parse yet (BuildMessage or AggregateError) or is gone (ENOENT) has no imports. A missing, unparsable or wrong-shaped manifest gives no manifest.
  • Package install: a missing or unparsable lockfile or manifest is skipped as before.
  • Sandbox: a process group that is already gone (ESRCH or EPERM) falls back to killing the child directly. An invalid URL isn't a public host.
  • Workflow HTTP JSON reader: a refusal body that isn't a JSON object carries no code.
  • Dev-app start: now a named launchDevApp with try/finally instead of an IIFE. Its file-watch restart and page-report reader became named functions, and the ?? [] destructuring default is gone, all with the same behaviour.

Verification

  • Lint, format, typecheck and tests pass, and Triage's local check passes all code-pattern rules.

  • An independent review found three regressions:

    • a syntax error now throwing from the coder's write tool
    • EPERM from a dead process group on macOS
    • a null refusal body raising a raw TypeError

    All three are fixed. A second review, which probed Bun 1.4.4's actual error types, found the fixes correct and the rewrites behaviour-identical.

@linear-code

linear-code Bot commented Oct 31, 2026

Copy link
Copy Markdown

CL-11846

@corbits-triage

corbits-triage Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Triage will approve.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11846-keep-caught-errors-in-the-coders-build-tools branch from 7b0585e to 9b7e72f Compare October 31, 2026 08:42
@TheGreatAxios
TheGreatAxios merged commit 9b7e72f into main Oct 31, 2026
7 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-11846-keep-caught-errors-in-the-coders-build-tools branch October 31, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant