Repository navigation
fix(web): deny open coordinator approval when sending a chat message - #79
TheGreatAxios merged 3 commits into
Conversation
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/web/src/pages/workspace/index.tsx:1260-1477 nested-ternary: Nested ternary; use if statements or a lookup.apps/web/src/pages/workspace/index.tsx:1284-1477 nested-ternary: Nested ternary; use if statements or a lookup.apps/web/src/pages/workspace/index.tsx:1302-1477 nested-ternary: Nested ternary; use if statements or a lookup.
0f9c114 to
2ec9fc2
Compare
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
Nothing triage asked to change still fails, so this request no longer stands.
|
A text send does reject the parked tool. A send with a file does not. Plain chat, question replies, suggested replies, and undoing a typed yes go through
|
Closes CL-11954
Sending a chat message while a coordinator approval card (
openApproval, such asdesign_app,approve_document, orrequest_approval) is open now denies that card (choice: "no") before delivering the message, so the parked coordinator wakes to read the person's message instead of remaining held onSignalAwaited.typedYescontinues to hold plain affirmations for approval after the countdown, undoing the countdown denies the open approval before sending the words, andchooseApproachapproves a matching approach card without double-deciding it.Verified:
bun --conditions=intx-src test apps/web/src/pages/workspace/typed-yes.test.ts(5 pass, 0 fail)bun --conditions=intx-src test apps/web/src(24 pass, 0 fail)bun run lint(exit 0)bun run format:check(exit 0)bun run typecheck(exit 0)bun run vendor:verify(exit 0)bun run pins:verify(exit 0)