Repository navigation
fix(web): deny open coordinator approval when sending a chat message - #77
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
TheGreatAxios
force-pushed
the
cl-11954-deny-pending-coordinator-approval-when-the-person-sends-a
branch
from
November 2, 2026 03:54
24f29b8 to
0f9c114
Compare
TheGreatAxios
deleted the
cl-11954-deny-pending-coordinator-approval-when-the-person-sends-a
branch
November 2, 2026 04:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11954
Sending a chat message while a coordinator approval card (
openApproval, such asdesign_app,approve_document, orrequest_approval) is open now denies that card (choice: "no") before delivering the message, so the parked coordinator wakes to read the person's message instead of remaining held onSignalAwaited.typedYescontinues to hold plain affirmations for approval after the countdown, undoing the countdown denies the open approval before sending the words, andchooseApproachapproves a matching approach card without double-deciding it.Verified:
bun --conditions=intx-src test apps/web/src/pages/workspace/typed-yes.test.ts(5 pass, 0 fail)bun --conditions=intx-src test apps/web/src(24 pass, 0 fail)bun run lint(exit 0)bun run format:check(exit 0)bun run typecheck(exit 0)bun run vendor:verify(exit 0)bun run pins:verify(exit 0)