Repository navigation
fix(artifacts): scope coordinator and writer write_artifact schemas to their kinds - #76
Merged
TheGreatAxios merged 5 commits intoNov 2, 2026
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
TheGreatAxios
force-pushed
the
cl-11952-scope-coordinator-and-writer-write_artifact-schemas-to-the
branch
from
November 2, 2026 03:48
af5345b to
b99a7e5
Compare
corbits-triage
Bot
dismissed
their stale review
November 2, 2026 03:52
Nothing triage asked to change still fails, so this request no longer stands.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
WriterDocumentWrite is a union so approaches is a field only when kind is approaches. The writer tool rejects the key on the other kinds before POST.
constraints, product_requirements, and build_plan each accept only kind, title, content, and openQuestions. approaches is the only arm that also accepts approaches.
Contributor
Author
|
Currently the removal of top level object is causing the head of this PR to be incompatible with Anthropic, fixing as it's being used in relation to the Designer Improvement PR |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11952
The coordinator's
write_artifacttool now usesBriefWrite(kind: "problem_brief",title,content, optionalopenQuestions, with noapproachesfield or other document kinds). The writer'swrite_artifacttool usesWriterDocumentWrite, an object schema scoped to the writer kinds (constraints,approaches,product_requirements,build_plan) that narrowsapproachestokind === "approaches"while keeping top-leveltype: "object"intoJsonSchema()for provider tool registration. Both@corbits-builder/coordinator(0.35.1) and@corbits-builder/writer(0.7.1) are patch-bumped.Verified:
bun --conditions=intx-src test apps/hub/src/artifacts/tools.test.ts apps/hub/src/projects/errors.test.ts(5 pass, 0 fail, including top-levelinputSchema.type === "object"across all roles)bun fmt --no-script --check,oxlint --deny-warnings, andbun check(exit 0)