Skip to content

fix(web): show action errors as toasts - #75

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-11948-show-action-errors-as-one-quiet-toast-not-the-red-inline-bar
Nov 2, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-11948-show-action-errors-as-one-quiet-toast-not-the-red-inline-bar

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-11948

Action failures that were a sentence-only error banner now use toast.error, the same quiet treatment as an import failure. Starting a project from home no longer renders the inline bar between the headline and the prompt.

Persistent page-state banners stay inline: the hub not answering, setup incomplete, a catalog or list that failed to load, and an invitation that could not be read. Connect-a-provider and import-approval stay inline because they carry a next step. .banner.is-error no longer sets a destructive border, so any remaining error banner is not a red outline. profiles.tsx and profile-select.tsx were not edited.

Verified:

  • bun check --no-script (exit 0, 762 files)
  • bun check --no-script -p packages/client (exit 0)
  • bun check --no-script -p packages/zip (exit 0)
  • bun check --no-script -p apps/web (exit 0)
  • bun run lint (exit 0)
  • bun run format:check (exit 0)
  • bun test ./apps/web/src (22 pass, 0 fail, exit 0)

@linear-code

linear-code Bot commented Nov 2, 2026

Copy link
Copy Markdown

CL-11948

@corbits-triage

corbits-triage Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 2, 2026
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Gist creation rejected the PNGs (gh gist create: binary file not supported). The shots are attached on this comment instead.

  1. Home page after submitting a too-short prompt (short). The failure is a toast: "At least ten characters to start a project." There is no red inline .banner.is-error between "What do you want to build today?" and the prompt.
    Home failure as a toast, no red inline bar

  2. Import confirmation stays an inline banner (not a toast). The file was not imported; Cancel was used.
    Import confirm still an inline banner

Taken with Playwright (chromium, headless) against this branch's Vite app on http://localhost:5190, proxied to the existing hub at 127.0.0.1:8000. Ports 8000 and 5173 were left running. Sidebar project titles were replaced with the word Project before the shot.

@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 4b484d0 Nov 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant