Skip to content

feat(web): toggle a new profile as the default - #73

Merged
TheGreatAxios merged 4 commits into
mainfrom
cl-11946-ask-which-profile-is-the-default-when-a-second-profile-is
Nov 2, 2026
Merged

TheGreatAxios merged 4 commits into
mainfrom
cl-11946-ask-which-profile-is-the-default-when-a-second-profile-is

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-11946

When a new profile is saved and at least one other profile already exists (shipped or custom), the profiles screen asks which profile is the default. The list includes the new profile and the previous ones. Confirming writes that id to ModelChoice.profile through the existing personal-settings save. Creating the first profile, when nothing else exists, keeps today's save and does not ask. Editing an existing profile does not ask again.

Verified:

  • bun test ./apps/web/src/pages/profiles.test.ts — 3 pass, 0 fail
  • bun --bun run oxlint --deny-warnings on the changed files — 0 warnings
  • bun check --no-script -p apps/web — no type errors
  • pre-commit hook: format, oxlint, and bun check across hub, client, zip, and web — passed

@linear-code

linear-code Bot commented Nov 2, 2026

Copy link
Copy Markdown

CL-11946

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventional commits: Ask which profile is the default when a second profile is added isn't a conventional commit
  • Conventions: added code matches a code pattern

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventional commits: Ask which profile is the default when a second profile is added isn't a conventional commit
  • Conventions: added code matches a code pattern

@TheGreatAxios TheGreatAxios changed the title Ask which profile is the default when a second profile is added feat(web): ask which profile is the default Nov 2, 2026
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Screenshots of the default-profile dialog on this branch (d0a67e8), from this worktree's web app on port 5321, proxied at the existing hub. Settings → Profiles already lists shipped profiles (Anthropic Default is active). Choosing New profile, starting from an existing profile, and saving opens this dialog instead of writing settings.

Lead sentence: "New projects start on the one you pick." The new profile is one of the choices, next to the profiles that already exist. Nothing is stored until Set default. This pass used Cancel; the new name was not listed afterward.

Settings → Profiles, with the dialog open:

Settings Profiles with the default-profile dialog open

The dialog (Which profile is the default? / Set default):

Default-profile dialog: New projects start on the one you pick

@TheGreatAxios TheGreatAxios changed the title feat(web): ask which profile is the default feat(web): toggle a new profile as the default Nov 2, 2026

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern
    • apps/web/src/pages/profiles.tsx:279-283 nested-ternary: Nested ternary; use if statements or a lookup.
    • apps/web/src/pages/profiles.tsx:344-354 promise-chain: Promise chain; use async/await with try/catch.

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Screenshot of Settings → Profiles → New profile on this branch (form not submitted).

When a default already exists, the old “Which profile is the default?” dialog is gone. The new-profile form shows a switch labeled “Do you want to make this your new default profile? It will replace Anthropic Default.”

New profile form with the replace-default switch

@TheGreatAxios
TheGreatAxios force-pushed the cl-11946-ask-which-profile-is-the-default-when-a-second-profile-is branch from 8de7e0e to a6373ff Compare November 2, 2026 09:03
@corbits-triage

corbits-triage Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Triage will approve, request review.

@corbits-triage
corbits-triage Bot dismissed stale reviews from themself November 2, 2026 09:05

Nothing triage asked to change still fails, so this request no longer stands.

@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit c8c141a Nov 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant