Repository navigation
Conversation
A coder's package request raises no room event, so the workspace page read the open decisions only on a room reload and the person saw no card until they reloaded the page, while the coder waited on them. Poll the project's run states while any run is live and read the open decisions again whenever the set of runs held on an approval changes. Closes #62
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
Contributor
Author
|
Continued, rebased onto main (which now reads open decisions through TanStack Query), with the triage finding fixed, in a replacement pull request from branch fix/poll-open-decisions-main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
What changed
apps/web/src/pages/workspace/agent-activity.tsxgainsuseProjectRunStates, which polls the project's run states every 5 seconds while any run is live (10 seconds otherwise), andheldOnApproval, which folds the runs in theapprovalstate into one string an effect can depend on.apps/web/src/pages/workspace/index.tsxdepends on that string in the effect that reads the open decisions, so the decision card appears within one poll of a specialist parking on an approval. The room reload still triggers it as before.The run-states endpoint already reports
approvalfor a run whose latest event is a park on an approval; the live-app pane polls it for the same reason, so no hub change is needed.Why
A coder parked on an
install_packagesapproval raises no room event. The page read the open decisions only on a room reload, so the "wants to install" card never appeared until the person reloaded the page, while the coder waited on them for as long as that took.How it was verified
./node_modules/.bin/tsc --noEmit -p apps/webpasses.bun --conditions=intx-src test apps/web/src/pages/workspacepasses (20 tests).oxlint --deny-warningsand Prettier pass on the changed files.