Repository navigation
feat(artifacts): file approval_package with source pins and secret scan - #58
Merged
TheGreatAxios merged 1 commit intoNov 2, 2026
Conversation
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
force-pushed
the
cl-11932-file-approval-packages-as-a-versioned-document-kind
branch
from
November 2, 2026 03:40
6cddf64 to
331d923
Compare
corbits-triage
Bot
dismissed
their stale review
November 2, 2026 03:43
This pull request is no longer ready to approve, so this approval no longer stands.
corbits-triage
Bot
dismissed
their stale review
November 2, 2026 05:02
Nothing triage asked to change still fails, so this request no longer stands.
corbits-triage
Bot
added
Triage: Ready
Triage: Waiting for CI
Triage: Not Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
corbits-triage
Bot
dismissed
their stale review
November 2, 2026 05:08
This pull request is no longer ready to approve, so this approval no longer stands.
TheGreatAxios
force-pushed
the
cl-11932-file-approval-packages-as-a-versioned-document-kind
branch
from
November 2, 2026 05:08
3f747fb to
80364b3
Compare
corbits-triage
Bot
dismissed stale reviews from themself
November 2, 2026 06:36
Nothing triage asked to change still fails, so this request no longer stands.
corbits-triage
Bot
added
Triage: Ready
and removed
sensitive: medium
Triage: Ready
labels
TheGreatAxios
changed the base branch from
cl-11930-give-agents-deck-tools-that-check-and-render-decks
to
main
November 2, 2026 08:46
TheGreatAxios
dismissed
corbits-triage[bot]’s stale review
November 2, 2026 08:46
The base branch was changed.
TheGreatAxios
enabled stacked auto-merge
November 2, 2026 08:46
TheGreatAxios
force-pushed
the
cl-11932-file-approval-packages-as-a-versioned-document-kind
branch
from
November 2, 2026 08:53
983f5a1 to
852abac
Compare
TheGreatAxios
disabled stacked auto-merge
November 2, 2026 09:03
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
corbits-triage
Bot
dismissed
their stale review
November 2, 2026 09:14
Nothing triage asked to change still fails, so this request no longer stands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11932 (Slice 2 of 5 for CL-11929; stacked on
cl-11930-give-agents-deck-tools-that-check-and-render-decks).Summary
approval_packagetoArtifactKind(packages/schemas/src/artifact.ts) withApprovalPackageManifest,ApprovalPackageBundle,ApprovalPackageSourceRef, andMAX_APPROVAL_PACKAGE_BYTES.approval_packageversions in the Hub (apps/hub/src/artifacts/approval-package.ts):manifest.sourcesentry must match a filed project document'sversionandsha256(invalid_package_sourceon mismatch;appandapproval_packagesources refused).package_contains_secretnaming only the file, never the secret value), plus rejection of live-app URLs anddemoLoginblocks.pptxBase64andpdfBase64whenread_artifactreads anapproval_packageso agents inspect the structured JSON and manifest without loading binary payloads into context.approval_packagein the workspace reading pane (apps/web/src/pages/workspace/approval-package-preview.tsx) with Slides, PDF, and Sources views.