Repository navigation
fix(hub): settle a failed helper notice so it never blocks the next - #49
Merged
TheGreatAxios merged 1 commit intoNov 2, 2026
Conversation
|
Triage: Unsure Asking a maintainer about:
Changed since the last verdict (Fail at |
TheGreatAxios
force-pushed
the
cl-11918-stop-one-undeliverable-helper-notice-from-blocking-the-rest
branch
from
November 1, 2026 18:41
a5dfe01 to
c2a47c3
Compare
corbits-triage
Bot
dismissed
their stale review
November 1, 2026 18:43
Nothing triage asked to change still fails, so this request no longer stands.
TheGreatAxios
enabled auto-merge
November 1, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a helper agent (writer, designer or coder) finishes or fails with an unanswered assignment, the hub sends the project's coordinator a note saying so. Interchange doesn't send this notice itself yet, so the hub has a small loop that checks ended runs in order (
ended_at), one at a time across the hub.notified: false), logged, and skipped on future passes so the loop moves on to the next one. Malformed mail headers/MIME are caught inside the same error handling so they can't crash the pass either.test/e2e/specialist-end-notices.test.ts) on real Postgres with an older notice whose coordinator mail fails (500) plus a newer one with malformed multipart mail. Fails onmain, passes with the fix.onFailure/ pushing the notice back) rather than a hub polling loop.Supersedes #43.
Closes CL-11918