Skip to content

test(writer): run the writer on scripted model turns in-process - #45

Closed
TheGreatAxios wants to merge 1 commit into
mainfrom
cl-11897-add-a-fake-model-server-that-tests-can-bind-a-role-to
Closed

TheGreatAxios wants to merge 1 commit into
mainfrom
cl-11897-add-a-fake-model-server-that-tests-can-bind-a-role-to

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-11897.

What changed

  • New workflows/writer/src/model-turns.test.ts: runs the writer's own agent and workflow through runLocal with Interchange's real step invoker, with model turns scripted by @intx/inference-testing (call write_artifact with the constraints document, then reply). Asserts the run completes and the document is filed exactly once.
  • workflows/writer devDependencies: @intx/inference-testing, @intx/workflow-host, @intx/storage-isogit (workspace).

Verified

  • Replacing the scripted tool call with plain text fails the test (nothing filed).
  • lint, format:check, typecheck, vendor:verify, pins:verify clean; bun run test 71 pass.

@linear-code

linear-code Bot commented Oct 31, 2026

Copy link
Copy Markdown

CL-11897

@corbits-triage

corbits-triage Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Triage: Unsure

Asking a maintainer about:

  • added code matches a code pattern: workflows/writer/src/model-turns.test.ts:88 A hand-rolled sleep; wait on an event, or on an Interchange wait, retry or timeout where one exists.

Notes:

  • changes sensitive paths: locks: bun.lock

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern

@corbits-triage
corbits-triage Bot dismissed their stale review October 31, 2026 22:09

Nothing triage asked to change still fails, so this request no longer stands.

corbits-triage[bot]
corbits-triage Bot previously approved these changes Oct 31, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-11897-add-a-fake-model-server-that-tests-can-bind-a-role-to branch from 6b72b47 to f1809e7 Compare October 31, 2026 22:42
@TheGreatAxios TheGreatAxios changed the title test: run the writer workflow against a local fake model server test: mock the writer's model turns in-process Oct 31, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-11897-add-a-fake-model-server-that-tests-can-bind-a-role-to branch from f1809e7 to 6db4415 Compare October 31, 2026 22:46
@TheGreatAxios
TheGreatAxios marked this pull request as draft November 1, 2026 17:52
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review November 1, 2026 17:52
@TheGreatAxios
TheGreatAxios force-pushed the cl-11897-add-a-fake-model-server-that-tests-can-bind-a-role-to branch from 6db4415 to b372b21 Compare November 1, 2026 18:22
@TheGreatAxios TheGreatAxios changed the title test: mock the writer's model turns in-process test(writer): run the writer on scripted model turns in-process Nov 1, 2026
@TheGreatAxios
TheGreatAxios marked this pull request as draft November 1, 2026 18:39
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review November 1, 2026 18:39
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Closing: model-turns.test.ts redefines write_artifact with an inline mock, uses Interchange's default director instead of the writer's compactingDirector, and scripts model replies that ignore the prompt—so it only tests Interchange's harness rather than Builder. Full-pipeline and per-role recorded-turn tests against real tools and workflow entries are tracked under CL-11938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant