Skip to content

fix(workflows): end stalled writer and reviewer steps after 10 minutes - #44

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-11894-give-writer-and-reviewer-steps-a-native-timeout
Nov 1, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-11894-give-writer-and-reviewer-steps-a-native-timeout

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-11894.

What changed

  • Writer and reviewer steps get a native step timeout of 10 minutes, the default in each workflow package; a host can pass stepTimeoutMs to change it (previously only the run lifetime bounded them). No retry: a second attempt would redo work the first may already have filed or mailed.
  • (vendor) commit: when a step's own timer fires, its StepFailed records error.code: "step-timeout" (the event's existing optional code field, as crash-mid-invocation already does) with a message naming the step and the limit, instead of a bare "The operation was aborted.". Outer cancellation is unchanged. Manifest updated.

Verified

  • New workflows/writer/src/workflow.test.ts runs the real writer workflow in the in-memory runtime with a model that never answers: exactly one StepFailed on write with code: "step-timeout", then RunFailed.
    • Fails without the workflow timeout (run never settles) and without the vendor patch (no code).
  • bun run lint, format:check, typecheck, vendor:verify clean; bun run test 71 pass; packaged.test.ts 3 pass; vendored workflow runtime tests 385 pass.

@linear-code

linear-code Bot commented Oct 31, 2026

Copy link
Copy Markdown

CL-11894

@corbits-triage

corbits-triage Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Triage: Unsure

Asking a maintainer about:

  • changes sensitive paths: vendor: vendor/interchange.manifest.json, vendor: vendor/interchange/packages/workflow/src/runtime/run.ts

Notes:

  • Not confirmed: makes one focused change

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern

@TheGreatAxios
TheGreatAxios force-pushed the cl-11894-give-writer-and-reviewer-steps-a-native-timeout branch from 669c990 to 9e6ba10 Compare October 31, 2026 22:02
@corbits-triage
corbits-triage Bot dismissed their stale review October 31, 2026 22:03

Nothing triage asked to change still fails, so this request no longer stands.

@TheGreatAxios
TheGreatAxios marked this pull request as draft November 1, 2026 17:52
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review November 1, 2026 17:52
@TheGreatAxios
TheGreatAxios force-pushed the cl-11894-give-writer-and-reviewer-steps-a-native-timeout branch from 9e6ba10 to 8c26e98 Compare November 1, 2026 18:04
@TheGreatAxios TheGreatAxios changed the title fix(workflows): end stalled writer and reviewer steps after 30 minutes fix(workflows): end stalled writer and reviewer steps after 10 minutes Nov 1, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-11894-give-writer-and-reviewer-steps-a-native-timeout branch from 8c26e98 to a86e1ec Compare November 1, 2026 18:18
@TheGreatAxios
TheGreatAxios marked this pull request as draft November 1, 2026 18:39
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review November 1, 2026 18:39
@TheGreatAxios
TheGreatAxios force-pushed the cl-11894-give-writer-and-reviewer-steps-a-native-timeout branch from c384d74 to f2384d4 Compare November 1, 2026 19:12
@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 6e7e96c Nov 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant