Repository navigation
fix(workflows): end stalled writer and reviewer steps after 10 minutes - #44
Merged
TheGreatAxios merged 2 commits intoNov 1, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
|
Triage: Unsure Asking a maintainer about:
Notes:
|
TheGreatAxios
force-pushed
the
cl-11894-give-writer-and-reviewer-steps-a-native-timeout
branch
from
October 31, 2026 22:02
669c990 to
9e6ba10
Compare
corbits-triage
Bot
dismissed
their stale review
October 31, 2026 22:03
Nothing triage asked to change still fails, so this request no longer stands.
TheGreatAxios
marked this pull request as draft
November 1, 2026 17:52
TheGreatAxios
marked this pull request as ready for review
November 1, 2026 17:52
TheGreatAxios
force-pushed
the
cl-11894-give-writer-and-reviewer-steps-a-native-timeout
branch
from
November 1, 2026 18:04
9e6ba10 to
8c26e98
Compare
TheGreatAxios
force-pushed
the
cl-11894-give-writer-and-reviewer-steps-a-native-timeout
branch
from
November 1, 2026 18:18
8c26e98 to
a86e1ec
Compare
TheGreatAxios
marked this pull request as draft
November 1, 2026 18:39
TheGreatAxios
marked this pull request as ready for review
November 1, 2026 18:39
TheGreatAxios
force-pushed
the
cl-11894-give-writer-and-reviewer-steps-a-native-timeout
branch
from
November 1, 2026 19:12
c384d74 to
f2384d4
Compare
TheGreatAxios
enabled auto-merge
November 1, 2026 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11894.
What changed
timeoutof 10 minutes, the default in each workflow package; a host can passstepTimeoutMsto change it (previously only the run lifetime bounded them). No retry: a second attempt would redo work the first may already have filed or mailed.(vendor)commit: when a step's own timer fires, itsStepFailedrecordserror.code: "step-timeout"(the event's existing optionalcodefield, ascrash-mid-invocationalready does) with a message naming the step and the limit, instead of a bare "The operation was aborted.". Outer cancellation is unchanged. Manifest updated.Verified
workflows/writer/src/workflow.test.tsruns the real writer workflow in the in-memory runtime with a model that never answers: exactly oneStepFailedonwritewithcode: "step-timeout", thenRunFailed.code).bun run lint,format:check,typecheck,vendor:verifyclean;bun run test71 pass;packaged.test.ts3 pass; vendored workflow runtime tests 385 pass.