Repository navigation
refactor(tools-handoff): move the coordinator hand-off tools into a package - #42
Closed
Conversation
|
Triage: Unsure Asking a maintainer about:
Stacked on #41: only this pull request's own changes were checked. Changed since the last verdict (Fail at |
TheGreatAxios
force-pushed
the
cl-11880-move-the-coordinators-hand-off-tools-into-a-tools-handoff
branch
from
October 31, 2026 22:03
4aa66f5 to
49750ba
Compare
corbits-triage
Bot
dismissed
their stale review
October 31, 2026 22:10
Nothing triage asked to change still fails, so this request no longer stands.
Contributor
Author
|
Closing: the decoupling plan on CL-11879 (adopt @corbits/artifacts with Builder rules in its write hook, run-scoped routes, tools that know nothing about projects or tenants) reshapes this package. It will be redone under that plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the coordinator's hand-off tools (ask questions, request approval, deploy writer, review, deploy coder, instruct coder, design app) out of the 700-line
apps/hub/src/projects/deploy-tools.tsinto@corbits-builder/tools-handoff..exports one plain function per tool,(args, deps), plusHandoffConfig,RefusalandrefusalText, so a workflow action can call the logic withoutdefineTool../sidecar-bundleexportscreateDeployTools(config, scope?)andDEPLOY_TOOLS(still@corbits-builder/deploy/tools, so grants are unchanged).HandoffConfig; the hub fills it fromapps/hub/src/configinapps/hub/src/projects/handoff-config.ts. Wording stays in config and is baked in at bundle time, and the bundle hash versions it as before. Macros stay hub-side.awaitingApproval(filed, agentApproves)takes the preference result as a boolean; its two hub callers passagentDecidesApprovals(preferences).handoffConfig.Stacked on #41. Closes CL-11880
Verification
lint,format:check,typecheck,test(71 pass);packaged.test.ts,deploy-tools.test.tsandcoordinator-run-grants.test.tspass.design_appdescription byte-identical.Refusal) are fixed.