Repository navigation
refactor(tools-skills): move the skill-reading tool into a package - #39
Closed
TheGreatAxios wants to merge 3 commits into
Conversation
Closes CL-11879
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Stacked on #37: only this pull request's own changes were checked. Notes:
Triage will approve, request review. Changed since the last verdict (Fail at |
corbits-triage
Bot
dismissed
their stale review
October 31, 2026 22:05
Nothing triage asked to change still fails, so this request no longer stands.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
force-pushed
the
cl-11879-move-the-hub-access-tools-into-a-tools-hub-package
branch
from
October 31, 2026 22:55
baa6ec6 to
782bfce
Compare
Contributor
Author
|
Closing: the decoupling plan on CL-11879 (adopt @corbits/artifacts with Builder rules in its write hook, run-scoped routes, tools that know nothing about projects or tenants) reshapes this package. It will be redone under that plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
read_skillfrom the hub into@corbits-builder/tools-skills: logic (read-skill.ts), definition (definitions.ts) and thedefineToolbundle (createSkillTools). The coordinator, writer and coder import it from the package; the hub copy is gone.The bundle id stays
@corbits-builder/skills/tools, since grant names are built from it. The package has nointerchange.toolsentry:createSkillToolstakes each role's skill names, as before.Stacked on #37. Closes CL-11884
Verification
lint,format:check,typecheck,test(71 pass);packaged.test.tsbuilds the real workflow bundles.read_skillin each (every skill, parts 1–3, both error paths): byte-identical output.