Repository navigation
fix(web): emphasise only the chosen approach once one is chosen - #28
Merged
TheGreatAxios merged 2 commits intoOct 31, 2026
Conversation
The recommended approach card kept its emphasis after the person chose another, so it still looked selected. Emphasis now follows the choice; the recommended card keeps its badge. Closes CL-11869
Cards carry data-recommended and data-chosen; the clicked card counts as chosen while the choice is sending.
TheGreatAxios
marked this pull request as ready for review
October 31, 2026 17:03
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
Contributor
Author
Before and afterReal
Source: https://gist.github.com/TheGreatAxios/9bdfb4b7c07c66a721d98bc4023ddfcc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11869
What changed
data-recommendedanddata-chosen(set on the chosen card, and on the clicked card while the choice is sending).Verification
bun run typecheck,bun run lint,bun run format:checkpass.apps/web/srchas a recommended-vs-chosen pattern.