Repository navigation
fix(hub): retry model errors before ending the turn - #27
Merged
TheGreatAxios merged 2 commits intoOct 31, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Every inference from the compacting director retries an overloaded, slow or rate-limited model on a 2/8/30 s schedule, bounded to 5 minutes and one retry for a stalled stream. Once it gives up, a designer or coder run fails so the coordinator gets the ended notice; the coordinator still replies with the error. replyOnRunaways becomes replyOnFailure. Closes CL-11871
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. Changed since the last verdict (Fail at |
corbits-triage
Bot
dismissed
their stale review
October 31, 2026 17:07
Nothing triage asked to change still fails, so this request no longer stands.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11871
What changed
compactingDirectorputs a retry policy on everyinferaction, including the inner default director's:retryableandquota_exhaustedretry after 2 s, 8 s, 30 s;timeoutretries once; retries stop after 5 minutes or when a retry-after exceeds 60 s. A longer retry-after wins.model_unavailable: <category>: <message>, so the existing specialist-ended notice reaches the coordinator. The coordinator keeps replying with the error.replyOnRunawaysis renamedreplyOnFailure, since it now covers model failures too.compaction.test.ts.Verification
bun test --conditions=intx-src apps/hub/src/workflows/compaction.test.ts: 2 pass. Covers the schedule on both the inner director's and the resample path'sinfer, the 5 min budget, one timeout retry, retry-after under and over the cap, fatal errors, specialist failure and the coordinator reply text. Both tests failed with the change made inert.bun run typecheck,bun run lint,bun run format:checkpass.