Repository navigation
fix(hub): let the person's ask decide how many designs start - #224
Merged
Merged
Conversation
design_app treated the project's Design concepts preference as a hard cap on the concepts at work, so when the person asked the coordinator for five looks with the preference at three, the hub refused with too_many_concepts and the coordinator told them to change Settings, which cannot reach a running project. The preference now guides the coordinator only when the person names no number, and the tool refuses only above the ceiling the preference offers (five), counting designers already started. The preference guidance, the design_app description and the artifact list's note on preferenceGuidance all say that what the person says in the conversation wins.
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
dismissed
their stale review
November 8, 2026 13:58
Nothing triage asked to change still fails, so this request no longer stands.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Root cause
design_apptreated the project's Design concepts to compare preference as a hard cap on the concepts at work. When the person asked the coordinator for five looks while the project held Three, the hub refused withtoo_many_concepts, and the coordinator told the person to change Settings. A project keeps the preferences its creator had when it started, so that advice could never reach the running project, and the product rule that what you say in the conversation wins was broken.Fix
design_appdescription says the person's ask comes first, and the artifact list describespreferenceGuidanceas how the person wanted to work when the project started, with the conversation winning over it.Verification
deploy-tools.test.tsnow starts three designers with the preference at Two, and refuses only when the in-flight concepts plus the new ones exceed five.bun fmt --checkon Bun 1.4.4 passes after one wrapped line was reformatted. Triage policy check: 6 of 6 passed.